-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed NetworkNeighbors #198
base: main
Are you sure you want to change the base?
Removed NetworkNeighbors #198
Conversation
btw, when you create commits, can you use the |
Yeahh, I will make sure to do it. I actually wanted to resolve the codegen issue first, and then merge the two commits and then signoff. |
Signed-off-by: JAYANT PRANJAL <[email protected]>
031daed
to
1d251cf
Compare
@jayantpranjal0 why did you remove networkpolicy/v1 and moved up the content of v2 ? This is the surest way of breaking API compabitility. |
I found the difference between networkpolicy/v1 and networkpolicy/v2 to be that v1 implements the functions using NetworkNeighbors, whereas v2 does so through NetworkNeighborhood. There was one more minor change in a function mergeEgressRulesByPorts but both did the same thing, only a minor change in the way an object was created. So, ig v1 was for NetworkNeighbors compatibility. So, I removed it and moved up the contents of v2 to rather just use it as default, as we had to remove NetworkNeighbors completelely. |
please don't do that... you can modify the v1 functions to panic but keep the existing paths |
Okayy, I'll modify the v1 functions to panic instead of removing them completely. |
Deprecate NetworkNeighbors